Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c1x Bid Adapter: adding back adapter with updated pbjs compliance #8706

Merged
merged 24 commits into from
Aug 2, 2022

Conversation

sasikumar-c1x
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
        bidder: 'c1x',
        params: {
            placementId: 'div-gpt-ad-1654940683355-0',
            dealId: '1233' // optional parameter
        }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer - [email protected]
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@vishnu1211

@ChrisHuie ChrisHuie changed the title Adding the removed bid adapter (c1xBidAdapter) c1x Bid Adapter: adding back adapter with updated pbjs compliance Jul 25, 2022
@ChrisHuie ChrisHuie requested a review from ncolletti July 25, 2022 12:04
modules/c1xBidAdapter.js Outdated Show resolved Hide resolved
modules/c1xBidAdapter.js Show resolved Hide resolved
modules/c1xBidAdapter.md Show resolved Hide resolved
modules/c1xBidAdapter.js Outdated Show resolved Hide resolved
modules/c1xBidAdapter.js Show resolved Hide resolved
@ncolletti
Copy link
Contributor

Could a PR be opened on the Prebid Website repo to update your adapter dev docs markdown file?

https://github.com/prebid/prebid.github.io/blob/d2cc4a4a542abd57be212fe8b3b13a788b48da08/dev-docs/bidders/c1x.md

@sasikumar-c1x
Copy link
Contributor Author

sasikumar-c1x commented Jul 29, 2022

Hi @ncolletti ,

PR for the dev docs in the prebid website repo is created prebid/prebid.github.io#3938.

cc: @vishnu1211

@ncolletti ncolletti added the LGTM label Aug 2, 2022
Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncolletti ncolletti merged commit d46661a into prebid:master Aug 2, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
…ebid#8706)

* C1X Adapter GDPR Support

* remove the redundant userSync

* fixed keyword spacing issue

* c1x adapter changes

* c1x adapter latest changes

* added deal id support for ssp endpoint

* changes for ne bidder parameters in md file

* changes

* changes

* test cases added

* Test cases changes

* test cases added

* test cases changes

* test cases changes

* changes

* changes

* changes

* changes

* changes for log

* changes suggested from PR

Co-authored-by: Cathy Huang <[email protected]>
Co-authored-by: sasikumar dharmaraj <[email protected]>
Co-authored-by: Devyani Choubey <[email protected]>
Co-authored-by: devyaniChoubey <[email protected]>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
…ebid#8706)

* C1X Adapter GDPR Support

* remove the redundant userSync

* fixed keyword spacing issue

* c1x adapter changes

* c1x adapter latest changes

* added deal id support for ssp endpoint

* changes for ne bidder parameters in md file

* changes

* changes

* test cases added

* Test cases changes

* test cases added

* test cases changes

* test cases changes

* changes

* changes

* changes

* changes

* changes for log

* changes suggested from PR

Co-authored-by: Cathy Huang <[email protected]>
Co-authored-by: sasikumar dharmaraj <[email protected]>
Co-authored-by: Devyani Choubey <[email protected]>
Co-authored-by: devyaniChoubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants