-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c1x Bid Adapter: adding back adapter with updated pbjs compliance #8706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapter Changes
changes for log
ChrisHuie
changed the title
Adding the removed bid adapter (c1xBidAdapter)
c1x Bid Adapter: adding back adapter with updated pbjs compliance
Jul 25, 2022
ncolletti
reviewed
Jul 26, 2022
Could a PR be opened on the Prebid Website repo to update your adapter dev docs markdown file? |
8 tasks
Hi @ncolletti , PR for the dev docs in the prebid website repo is created prebid/prebid.github.io#3938. cc: @vishnu1211 |
ncolletti
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
…ebid#8706) * C1X Adapter GDPR Support * remove the redundant userSync * fixed keyword spacing issue * c1x adapter changes * c1x adapter latest changes * added deal id support for ssp endpoint * changes for ne bidder parameters in md file * changes * changes * test cases added * Test cases changes * test cases added * test cases changes * test cases changes * changes * changes * changes * changes * changes for log * changes suggested from PR Co-authored-by: Cathy Huang <[email protected]> Co-authored-by: sasikumar dharmaraj <[email protected]> Co-authored-by: Devyani Choubey <[email protected]> Co-authored-by: devyaniChoubey <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
…ebid#8706) * C1X Adapter GDPR Support * remove the redundant userSync * fixed keyword spacing issue * c1x adapter changes * c1x adapter latest changes * added deal id support for ssp endpoint * changes for ne bidder parameters in md file * changes * changes * test cases added * Test cases changes * test cases added * test cases changes * test cases changes * changes * changes * changes * changes * changes for log * changes suggested from PR Co-authored-by: Cathy Huang <[email protected]> Co-authored-by: sasikumar dharmaraj <[email protected]> Co-authored-by: Devyani Choubey <[email protected]> Co-authored-by: devyaniChoubey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information
@vishnu1211