Triplelift Bid Adapter: outstream support #8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch TL Prebid up to the upstream
…acyFpd TL-26965: deprecate getLegacyFpd
…e-update TL-19850 Finished log error logic around floors functionality
…port-B TL-24341: Outstream support
robertrmartinez
approved these changes
Jul 28, 2022
1 task
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* alt outstream support * removes consoleLog * rename video ttl * multi-imp * simplify video if statement in buildPostBody * distinguish banner from video bid; temp solution for testing * adds tests for mediatype * remove console log * individual instream/outstream tests * simplify some functions * nitpick * adds media_type check * adds placement options to outstream * checks instream placement values * TL-19850 Finished log error logic around floors functionality * deprecates getlegacyFpd * remove console log * TL-19850 Changed functionlity of tests * restore logErrorSpy aftereach * removing pub name from test Co-authored-by: Dan Goldin <[email protected]> Co-authored-by: Patrick Loughrey <[email protected]> Co-authored-by: Patrick Loughrey <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* alt outstream support * removes consoleLog * rename video ttl * multi-imp * simplify video if statement in buildPostBody * distinguish banner from video bid; temp solution for testing * adds tests for mediatype * remove console log * individual instream/outstream tests * simplify some functions * nitpick * adds media_type check * adds placement options to outstream * checks instream placement values * TL-19850 Finished log error logic around floors functionality * deprecates getlegacyFpd * remove console log * TL-19850 Changed functionlity of tests * restore logErrorSpy aftereach * removing pub name from test Co-authored-by: Dan Goldin <[email protected]> Co-authored-by: Patrick Loughrey <[email protected]> Co-authored-by: Patrick Loughrey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Allows adunits configured as 'outstream' to be sent to endpoint
Allows adunits configured as 'outstream' AND 'banner' to be sent to endpoint within same impression object
exchange will return only one or the other
'banner' and 'instream' is still interpreted as instream-only
Modified banner+outstream tests to check for both objects
Added new tests for 'outstream only' and 'banner + incomplete outstream'
Outstream gets same TTL as Instream
Outstream placements:
if context=outstream and placement was not provided, set video.placement:3
if pub sets video.placement and it is not 3,4,5, set to placement:3
if pub sets as 3, 4, 5, keep as is