Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

33Across Bid Adapter: Obtain display-related attributes #8730

Merged
merged 11 commits into from
Jul 28, 2022
Merged

33Across Bid Adapter: Obtain display-related attributes #8730

merged 11 commits into from
Jul 28, 2022

Conversation

carlosfelix
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Obtain display-related client-side attributes and clients hints from browsers that support it

  • contact email of the adapter’s maintainer: [email protected]
  • official adapter submission

@carlosfelix carlosfelix force-pushed the master branch 2 times, most recently from b9e0f2c to 9cffb55 Compare July 23, 2022 17:10
@patmmccann patmmccann changed the title Obtain display-related attributes and browser client hints 33Across Bid Adapter: Obtain display-related attributes Jul 25, 2022
@patmmccann
Copy link
Collaborator

We're not allowing adapters to access these api's, please modify core and access from core

#8381

patmmccann
patmmccann requested changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User agent client hints should be gathered by core

modules/33acrossBidAdapter.js Outdated
}

function storeUaReducedData(uaData) {
storage.setDataInLocalStorage(UA_DATA_KEY, JSON.stringify(uaData));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why put this in storage?

@patmmccann patmmccann self-assigned this Jul 26, 2022
@patmmccann
Copy link
Collaborator

Update: discussed with 33across team on slack, updates pending

@macinjosh32
Copy link
Contributor

Hi Pat,
We're only intending to collect client hints within our adapter on a temporary basis (through end of Q3) so we can quickly understand the state of various browsers' UA deprecation. We'll be happy to switch the access over to enrichmentFpdModule thereafter if we decide we need it past Q3. It looks like several other modules, such sspBC's adapter and Just ID's User ID sub-module (via an external script) are already collecting these on a more permanent basis, so we were not anticipating any concerns as long as standards are being fairly applied across modules. Placing the values in storage is to help facilitate unit tests and ensure these were available upon initial request since the Client Hints API is asynchronous. Thanks in advance for your understanding.

@patmmccann
Copy link
Collaborator

We noticed that as well, which is why we drew the line in the sand to make sure no more were added #8381

Anthony Lin and others added 2 commits July 27, 2022 10:31
@anthonyjl92
Copy link
Contributor

Hi Pat, we removed the storage and client hints from this PR - are you able to review the remaining changes? Thanks!

@patmmccann patmmccann merged commit c94c8de into prebid:master Jul 28, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
@carlosfelix @anthonyjl92 @JacobKlein26
33Across Bid Adapter: Obtain display-related attributes (prebid#8730)
032db59 
* capture display-related client side attributes

* rename the client display attributes

* Obtain the UA entropy values

* apply CR feedback, reuse win constant

* pass gpid into build

* feedback changes

* fix missing native property in some browsers

* rename entropy fields

* only store entropy data when it's present

* remove client hints

Co-authored-by: Anthony Lin <[email protected]>
Co-authored-by: anthonyjl92 <[email protected]>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
@carlosfelix @anthonyjl92 @jorgeluisrocha
33Across Bid Adapter: Obtain display-related attributes (prebid#8730)
2400c89 
* capture display-related client side attributes

* rename the client display attributes

* Obtain the UA entropy values

* apply CR feedback, reuse win constant

* pass gpid into build

* feedback changes

* fix missing native property in some browsers

* rename entropy fields

* only store entropy data when it's present

* remove client hints

Co-authored-by: Anthony Lin <[email protected]>
Co-authored-by: anthonyjl92 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlosfelix @patmmccann @macinjosh32 @anthonyjl92