Relaido Bid Adapter: Add params for hashed canonical url. #8743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
reviewed
Jul 27, 2022
| @@ -104,9 +105,10 @@ function buildRequests(validBidRequests, bidderRequest) { | |||
| uuid: getUuid(), | |||
| pv: '$prebid.version$', | |||
| imuid: imuid, | |||
| canonical_url_hash: getCanonicalUrlHash(bidderRequest.refererInfo), | |||
There was a problem hiding this comment.
why do you want the url hash? why not just hash it server side?
There was a problem hiding this comment.
@patmmccann
The reason for hashing is to reduce the computational load on the server side. It also has the advantage of data reduction since the value is a fixed length.
patmmccann
reviewed
Jul 27, 2022
| // TODO: is 'page' the right value here? | ||
| ref: bidderRequest.refererInfo.page | ||
| }) | ||
| }); |
There was a problem hiding this comment.
can you remove the todo if you confirmed this is correct
There was a problem hiding this comment.
@patmmccann
todo comment removed. Thanks for the review.
patmmccann
requested changes
Jul 27, 2022
removed review comment.
patmmccann
approved these changes
Jul 28, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* add relaido adapter * remove event listener * fixed UserSyncs and e.data * fix conflicts * Add params for hashed canonical url. * Add params for hashed canonical url. removed review comment. Co-authored-by: ishigami_shingo <[email protected]> Co-authored-by: cmertv-sishigami <[email protected]> Co-authored-by: t_bun <[email protected]> Co-authored-by: n.maeura <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* add relaido adapter * remove event listener * fixed UserSyncs and e.data * fix conflicts * Add params for hashed canonical url. * Add params for hashed canonical url. removed review comment. Co-authored-by: ishigami_shingo <[email protected]> Co-authored-by: cmertv-sishigami <[email protected]> Co-authored-by: t_bun <[email protected]> Co-authored-by: n.maeura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Comment on the following review