Prebid Core: Handled edge cases for allowedAlternateBidderCodes functionality #8760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed net revenue to True
Syncing with Upstream
|
Hi team, I just wanted to bring it to your attention that the PBS team is actually planning to treat an empty array as "restrict all" instead of "allow all" as mentioned in the description here. |
jsnellbaker
approved these changes
Aug 2, 2022
jsnellbaker
added
needs 2nd review
|
@ncolletti can you please review this? |
ncolletti
added
LGTM
and removed
needs 2nd review
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
…ionality (prebid#8760) * Changed net revenue to True * handled edge cases * Empty alternateBidderCodes will reject the bids Co-authored-by: Azhar <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
…ionality (prebid#8760) * Changed net revenue to True * handled edge cases * Empty alternateBidderCodes will reject the bids Co-authored-by: Azhar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We have made a few minor changes to the
allowedAlternateBidderCodesfunctionalityallowedAlternateBidderCodesarray also lowercase before comparison.allowedAlternateBidderCodesarray before comparison.