Multiple bid adapters: use auctionId for source.tid
#9074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
approved these changes
Oct 4, 2022
patmmccann
approved these changes
Oct 5, 2022
patmmccann
reviewed
Oct 6, 2022
| @@ -307,10 +307,10 @@ const ID_REQUEST = { | |||
| } | |||
| // In the single request mode, split imps between those going to the ad server and those going to extend server | |||
| if (extendImps.length) { | |||
| requests.push(formatRequest(extendImps, null, true)); | |||
| requests.push(formatRequest(extendImps, bidderRequest.auctionId, true)); | |||
There was a problem hiding this comment.
Prebid.js/modules/improvedigitalBidAdapter.js
Line 165 in f407e47
There was a problem hiding this comment.
@patmmccann, I missed that, but I don't think it has any effect now, because it's always overridden by this PR setting it to auctionID afterwards. Since all of that is being refactored in #8738 I think it's OK to leave.
There was a problem hiding this comment.
no problem; I changed the original issue to call out a bunch that i found where source was on one line and tid was on the next line
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This changes bid adapters that were setting
source.tid = bidRequests[0].transactionIdto useauctionIdinstead. This is not exhaustive - I just touched the adapters that were easy to grep for.Part of #8573