Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lotame Panorama Id System: bug fixes #9092

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Lotame Panorama Id System: bug fixes #9092

merged 2 commits into from
Oct 10, 2022

Conversation

Tonsil
Copy link
Contributor

@Tonsil Tonsil commented Oct 7, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

Does this change affect user-facing APIs or examples documented on http://prebid.org? No

Description of change

Contains a couple of fixes to bugs recently identified in the lotamePanoramaIdSystem module:

  1. In getProfileId, it wasn’t testing a cookie value for being empty before returning. It should look to localStorage in this case.
  2. In getFromStorage, it should check for null values, and also needs to convert a stored timestamp from a string to an integer before applying.

@Tonsil
GRUE-246 fixed bug to test for emnpty value before returning, fixed b…
3bfeb65 
…ug to check for null values and to convert a string to an int before treating it as a timestamp.
@Tonsil
GRUE-246 Removed trailing space.
1b525d0
@patmmccann patmmccann self-assigned this Oct 10, 2022
@patmmccann patmmccann self-requested a review October 10, 2022 14:02
@patmmccann patmmccann merged commit be1995b into prebid:master Oct 10, 2022
@Tonsil Tonsil deleted the lotamePanoramaIdSystem_bugfixes branch October 18, 2022 13:55
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
@Tonsil @JacobKlein26
Lotame Panorama Id System: bug fixes (prebid#9092)
254e896 
* GRUE-246 fixed bug to test for emnpty value before returning, fixed bug to check for null values and to convert a string to an int before treating it as a timestamp.

* GRUE-246 Removed trailing space.
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
@Tonsil @jorgeluisrocha
Lotame Panorama Id System: bug fixes (prebid#9092)
fa257a9 
* GRUE-246 fixed bug to test for emnpty value before returning, fixed bug to check for null values and to convert a string to an int before treating it as a timestamp.

* GRUE-246 Removed trailing space.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tonsil @patmmccann