Bidder Settings: Support for option to apply adapter bid adjustment to unknown bidder codes #9609

jlquaccia · 2023-03-01T00:43:21Z

Type of change

Feature

Description of change

Added optional configurable logic to to allow adapter bid adjustment functions to be invoked in the event a bidder code is uknown.

Other information

#8312

dgirardi · 2023-03-01T15:22:30Z

src/utils/cpm.js

-  const bidCpmAdjustment = bs.get(bidResponse?.bidderCode || bidRequest?.bidder, 'bidCpmAdjustment');
+
+  const adapterAllowAlternateBidderCodes = bs.get(bidResponse?.adapterCode || bidRequest?.bidder, 'allowAlternateBidderCodes');
+  const catchUnknownBidderCodesWithAdapterBidAdjustment = bs.get(bidResponse?.adapterCode || bidRequest?.bidder, 'catchUnknownBidderCodesWithAdapterBidAdjustment');


this setting (and variable) name is way too long, past the point of ridiculous. I'll offer adjustAlternateBids, or adjustAllBids.

what's the reason for looking at allowAlternateBidderCodes? If you have a bid from an alternate code (that is, one where adapterCode is different from bidderCode), it should mean that it was allowed already.

I can't make sense of the fallback bidResponse?.adapterCode || bidRequest?.bidder. If you are using bidRequest?.bidder, are you not just using the "normal" bid adjustment rules?

dgirardi · 2023-03-01T15:29:50Z

src/utils/cpm.js

@@ -2,9 +2,15 @@ import {auctionManager} from '../auctionManager.js';
 import {bidderSettings} from '../bidderSettings.js';
 import {logError} from '../utils.js';

-export function adjustCpm(cpm, bidResponse, bidRequest, {index = auctionManager.index, bs = bidderSettings} = {}) {
+export function adjustCpm(cpm, bidResponse, bidRequest, {index = auctionManager.index, bs = bidderSettings} = {}, gba = getBidAdjustment) {


gba is a very thin wrapper around bs. it gets confusing if you can "decouple" them; if I pass in a particular instance of bidderSettings, I would expect it to be used throughout. to me this looks like you're asking for the same thing twice.

jlquaccia · 2023-03-21T22:11:48Z

@dgirardi thanks for the feedback. I addressed what you brought up, could you take another look when you have the time?

dgirardi · 2023-03-22T16:05:30Z

src/utils/cpm.js

@@ -4,7 +4,10 @@ import {logError} from '../utils.js';

 export function adjustCpm(cpm, bidResponse, bidRequest, {index = auctionManager.index, bs = bidderSettings} = {}) {
  bidRequest = bidRequest || index.getBidRequest(bidResponse);
-  const bidCpmAdjustment = bs.get(bidResponse?.bidderCode || bidRequest?.bidder, 'bidCpmAdjustment');
+
+  const adjustForAlternateBids = bs.get(bidResponse?.adapterCode, 'adjustForAlternateBids');


adjustFor reads weird; we're adjusting the bids, not adjusting for the bids.

changed the var name to be just adjustAlternateBids

dgirardi · 2023-03-22T16:08:21Z

src/utils/cpm.js

-  const bidCpmAdjustment = bs.get(bidResponse?.bidderCode || bidRequest?.bidder, 'bidCpmAdjustment');
+
+  const adjustForAlternateBids = bs.get(bidResponse?.adapterCode, 'adjustForAlternateBids');
+  const scope = adjustForAlternateBids ? bidResponse?.adapterCode : bidResponse?.bidderCode || bidRequest?.bidder;


this means something else now - if I have a bid with {adapterCode: "adapter', bidderCode: 'bidder'}, and this config:

bidderSettings = { bidder: { bidCpmAdjustment: bidderAdjustment, }, adapter: { bidCpmAdjustment: adapterAdjustment, adjustForAlternateBids: true } }

then we are picking adapterAdjustment over bidderAdjustment; is that the intent? I think it's surprising behavior.

Yes, believe that is the intent from #8312 (or my interpretation at least), to provide Publisher's with a config option to handle a bidAdjustment by adapter. Do you think this would be a feature that we would want to merge in? Or would we want to pass on this one?

cc @patmmccann

discussed offline - we agreed that it makes sense to pick the more specific adjustment funcition; e.g., if we find an adjustment for bidder, we should pick it over the adapter's adjustment funcition even if the adapter says adjustForAlternateBids.

discussed briefly, if a publisher has a specific adjustment for 'friend_of_pubmatic' than it should be used regardless of flag adjustForAlternateBids, and we should fall back to that flag applying when there is no named bidder adjustment function match

thanks guys! makes sense with what you both are saying. Adjusted the logic just now with a new commit.

dgirardi · 2023-03-22T16:10:07Z

src/adapters/bidderFactory.js

    if (!!responseBidder && !!requestBidder && requestBidder !== responseBidder) {
      alternateBiddersList = isArray(alternateBiddersList) ? alternateBiddersList.map(val => val.trim().toLowerCase()).filter(val => !!val).filter(uniques) : alternateBiddersList;
-      if (!allowAlternateBidderCodes || (isArray(alternateBiddersList) && (alternateBiddersList[0] !== '*' && !alternateBiddersList.includes(responseBidder)))) {
+      if ((!adjustForAlternateBids && !allowAlternateBidderCodes) || !allowAlternateBidderCodes || (isArray(alternateBiddersList) && (alternateBiddersList[0] !== '*' && !alternateBiddersList.includes(responseBidder)))) {


what's this for - why would isInvalidAlternateBidder care about adjustments?

See what you mean, reverted my change for this line.

…nateBidder func

dgirardi · 2023-05-02T19:08:31Z

src/utils/cpm.js

+  const adapterCode = bidResponse?.adapterCode;
+  const bidderCode = bidResponse?.bidderCode || bidRequest?.bidder;
+  const adjustAlternateBids = bs.get(bidResponse?.adapterCode, 'adjustAlternateBids');
+  const scope = adjustAlternateBids && !globalBidderSettings.hasOwnProperty(bidderCode) ? adapterCode : bidderCode;


This should be equilvalent but avoids using getGlobal().bidderSettings (which defeats the purpose of injecting in bs as a dependency):

const bidCpmAdjustment = bs.getOwn(bidderCode, 'bidCpmAdjustment') || bs.get(adjustAlternateBids ? adapterCode : bidderCode, 'bidCpmAdjustment')`

jlquaccia · 2023-05-03T18:49:11Z

Hey @patmmccann, could you also review this one when you have a chance?

…o unknown bidder codes (prebid#9609) * support to default on adapter bidderSetting if config option is true * addressed review feedback * changed var name to adjustAlternateBids and refactored isInvalidAlternateBidder func * adjusted logic around adapter and bidder code * improvements * consolidate tests in single spec file * fix lint --------- Co-authored-by: Demetrio Girardi <[email protected]>

jlquaccia requested review from patmmccann and dgirardi March 1, 2023 00:43

jsnellbaker assigned dgirardi Mar 1, 2023

jsnellbaker added the feature label Mar 1, 2023

dgirardi reviewed Mar 1, 2023

View reviewed changes

jlquaccia added 2 commits March 21, 2023 11:20

support to default on adapter bidderSetting if config option is true

f6989f8

addressed review feedback

c42defd

jlquaccia force-pushed the ISSUE-8312 branch from cafb69c to c42defd Compare March 21, 2023 22:09

dgirardi reviewed Mar 22, 2023

View reviewed changes

changed var name to adjustAlternateBids and refactored isInvalidAlter…

f0300ad

…nateBidder func

patmmccann requested a review from dgirardi April 4, 2023 17:04

adjusted logic around adapter and bidder code

e228809

dgirardi reviewed May 2, 2023

View reviewed changes

dgirardi added 4 commits May 2, 2023 13:07

improvements

06890d4

Merge branch 'master' into ISSUE-8312

d17b45d

consolidate tests in single spec file

dbe91e3

fix lint

0f3da0c

dgirardi approved these changes May 2, 2023

View reviewed changes

jlquaccia mentioned this pull request May 5, 2023

Documentation for the adjustAlternateBids bidderSettings Functionality prebid/prebid.github.io#4547

Merged

2 tasks

patmmccann approved these changes May 6, 2023

View reviewed changes

patmmccann merged commit d5bfdee into prebid:master May 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bidder Settings: Support for option to apply adapter bid adjustment to unknown bidder codes #9609

Bidder Settings: Support for option to apply adapter bid adjustment to unknown bidder codes #9609

jlquaccia commented Mar 1, 2023

dgirardi Mar 1, 2023

dgirardi Mar 1, 2023

jlquaccia commented Mar 21, 2023

dgirardi Mar 22, 2023

jlquaccia Mar 29, 2023

dgirardi Mar 22, 2023

jlquaccia Mar 29, 2023

dgirardi Apr 4, 2023

patmmccann Apr 4, 2023 •

edited

Loading

jlquaccia Apr 6, 2023

dgirardi Mar 22, 2023

jlquaccia Mar 29, 2023

dgirardi May 2, 2023

jlquaccia commented May 3, 2023

Bidder Settings: Support for option to apply adapter bid adjustment to unknown bidder codes #9609

Bidder Settings: Support for option to apply adapter bid adjustment to unknown bidder codes #9609

Conversation

jlquaccia commented Mar 1, 2023

Type of change

Description of change

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jlquaccia commented Mar 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patmmccann Apr 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jlquaccia commented May 3, 2023

patmmccann Apr 4, 2023 •

edited

Loading