Axis Bid Adapter : initial release #9684
Conversation
|
Hey @PyjamaWarrior I think your code here is good. I'm just concerned with your endpoint. When I test locally I am getting the error Prebid axis ERROR: Server call for axis failed: 0. Continuing without bids. Are you able to test with the integration tests on your end? I believe this is because my local test is on http, not https, not certain though. I am also seeing 1000+ms response time from your server as well. Is this intended? |
|
Hey @PyjamaWarrior , just wanted to check in and see if you had any questions or anything. Are you still working on things on your end? |
modules/axisBidAdapter.js
Outdated
| coppa: config.getConfig('coppa') === true ? 1 : 0, | ||
| ccpa: bidderRequest.uspConsent || undefined, | ||
| gdpr: bidderRequest.gdprConsent || undefined, | ||
| tmax: config.getConfig('bidderTimeout') |
There was a problem hiding this comment.
please prefer the request object to config
There was a problem hiding this comment.
@PyjamaWarrior here is an example
Prebid.js/modules/riseBidAdapter.js
Line 421 in 509deaa
modules/axisBidAdapter.js
Outdated
| host, | ||
| page, | ||
| placements, | ||
| coppa: config.getConfig('coppa') === true ? 1 : 0, |
There was a problem hiding this comment.
please prefer the request object to config
There was a problem hiding this comment.
@PyjamaWarrior here is an example
Prebid.js/modules/riseBidAdapter.js
Line 328 in 509deaa
|
@Rothalack Can you check again, please? Now everything seems to be working fine. |
|
I'll have a look today. In the meantime, please try to address Pat's feedback above. I should have time to test things in an hour or two. |
|
@PyjamaWarrior I got a chance to test, everything looks good and is working. I still think you should address Pat's feedback about using the request instead of config above. |
|
Thanks so much @Rothalack ! I'll leave assigned to me to get this last change over the finish line. |
modules/axisBidAdapter.js
Outdated
| host, | ||
| page, | ||
| placements, | ||
| coppa: config.getConfig('coppa') === true ? 1 : 0, |
There was a problem hiding this comment.
@PyjamaWarrior here is an example
Prebid.js/modules/riseBidAdapter.js
Line 328 in 509deaa
modules/axisBidAdapter.js
Outdated
| coppa: config.getConfig('coppa') === true ? 1 : 0, | ||
| ccpa: bidderRequest.uspConsent || undefined, | ||
| gdpr: bidderRequest.gdprConsent || undefined, | ||
| tmax: config.getConfig('bidderTimeout') |
There was a problem hiding this comment.
@PyjamaWarrior here is an example
Prebid.js/modules/riseBidAdapter.js
Line 421 in 509deaa
There was a problem hiding this comment.
Two changes are currently required:
-
iabCat: ['IAB1-1', 'IAB3-1', 'IAB4-3'] is not an allowed parameter, please read this from ortb2.site.cat or pagecat. Publishers don't enjoy setting the same field in specific ways for each adapter. Feel free to include instructions on how publishers can set this parameter or link to https://docs.prebid.org/features/firstPartyData.html
-
You are failing your own test according to the last circleci run
|
@patmmccann I've fixed tests and iabCat. But i want to ask you about ortb2.site.cat. As you can see, i got this data from bidderRequest as you suggested and its same for all adUnits. Maybe its better to use ortb2Imp from validBidRequests to have categories for every adUnit separately? What do you think about that? |
|
IAB hangs it on the site object, but we allow it to change per request. see Supplying Auction-Specific Data |
doc - prebid/prebid.github.io#4424