Brid Bid Adapter: Initial adapter release #9800
Conversation
|
@jsnellbaker |
|
Hey Team, Any updates on when we can get a review here? |
|
@fowler446 @gwhigs Any estimate when this should be approved ? Thanks! |
|
@losmicar sorry. I will make sure and review this week |
|
Thanks @ChrisHuie any updates or timeline estimate about Brid adapter? Any kind of feedback will be useful. Thanks! |
|
@ChrisHuie any updates about the Brid.tv adapter? Please let us know when we can expect an update or if anything else is needed from our side. |
modules/bridBidAdapter.js
Outdated
| }, | ||
| bidId, | ||
| params, | ||
| auctionId, |
There was a problem hiding this comment.
this might be null, is that alright?
| }; | ||
| const bidderRequest = { | ||
| bidderCode: 'brid', | ||
| auctionId: '1d1a030790a475', |
There was a problem hiding this comment.
tests on this might fail if you cannot take nulls
There was a problem hiding this comment.
Hello @patmmccann, tests updated. All example requests now have bidId and auctionId specified. Is that what you meant, or we should modify "isBidRequestValid" method to check if bidId is present (although I don't see other modules have that)?
|
Hi @patmmccann , Let us know if anything else is needed in regards to the above or when can we expect the adapter to go live. |
grajzer
force-pushed
the
master
branch
2 times, most recently
from
b464286
to
c292fa3
Compare
* TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo Bid Adapter: Add GDPR/USP support * TargetVideo Bid Adapter: Add GDPR/USP support tests * TargetVideo Bid Adapter: Updating margin rule * Add Brid bid adapter * Brid adapter requested changes
* TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo Bid Adapter: Add GDPR/USP support * TargetVideo Bid Adapter: Add GDPR/USP support tests * TargetVideo Bid Adapter: Updating margin rule * Add Brid bid adapter * Brid adapter requested changes
* TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo bid adapter * TargetVideo Bid Adapter: Add GDPR/USP support * TargetVideo Bid Adapter: Add GDPR/USP support tests * TargetVideo Bid Adapter: Updating margin rule * Add Brid bid adapter * Brid adapter requested changes
Type of change
Description of change
Add new bidder adapter for Brid.