Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreePass Bid Adapter : initial release #9827

Merged
merged 19 commits into from
Jun 21, 2023

Conversation

czarpino
Copy link
Contributor

@czarpino czarpino commented Apr 19, 2023

Type of change

  • New bidder adapter

Description of change

New Bid Adapter from FreePass.

Please the ff parameters to validate the adapter:

{
    bidder: 'freepass',
    test: 1
}

Contact maintainer at [email protected]

Other information

Docs: prebid/prebid.github.io#4495

Testing with hello_world

Related discussion: #9712

Due to IP restriction we have prepared a US-based mock server to respond to external requests at 172.104.192.122. If this is not acceptable, please advice and we will try to prepare for external access to actual bidder service.

To test, please add the ff to your /etc/hosts

172.104.192.122 bidding-dsp.ad-m.asia

@ChrisHuie ChrisHuie changed the title FreePass BidAdapter FreePass Bid Adapter : initial release Apr 24, 2023
@czarpino
Copy link
Contributor Author

@mmoschovas Sorry, could you please advise about the error in the build. They seem unrelated to the PR changes.

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you're passing tests

@czarpino
Copy link
Contributor Author

@patmmccann Thanks for checking. I will look into it!

@czarpino
Copy link
Contributor Author

@patmmccann Thank you for the feedback. All tests should now be passing.

@czarpino
Copy link
Contributor Author

@patmmccann Sorry, if you get a chance, a re-review would be very appreciated. The PR has been updated and tests are now passing 🙏

@patmmccann patmmccann merged commit 5bfac11 into prebid:master Jun 21, 2023
2 checks passed
@patmmccann patmmccann self-assigned this Jun 21, 2023
github-ishara-chan-tung pushed a commit to ebuzzing/Prebid.js that referenced this pull request Jul 12, 2023
* Add FreePass Bid Adapter

* Add note about FreePass IdSystem

* Unrequire userId

* Add test flag

* Update official maintainer email

* Update official bidder service URL

* No credentials

Client does not need to send credentials

* Add md code type

Trigger ci

* Replace double with single quotes

* Append js to import

* Build mock request in local scope

* Update maintainer email
musikele pushed a commit to rubicon-project/Prebid.js that referenced this pull request Aug 28, 2023
* Add FreePass Bid Adapter

* Add note about FreePass IdSystem

* Unrequire userId

* Add test flag

* Update official maintainer email

* Update official bidder service URL

* No credentials

Client does not need to send credentials

* Add md code type

Trigger ci

* Replace double with single quotes

* Append js to import

* Build mock request in local scope

* Update maintainer email
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants