-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreePass Bid Adapter : initial release #9827
FreePass Bid Adapter : initial release #9827
Conversation
Client does not need to send credentials
@mmoschovas Sorry, could you please advise about the error in the build. They seem unrelated to the PR changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure you're passing tests
@patmmccann Thanks for checking. I will look into it! |
@patmmccann Thank you for the feedback. All tests should now be passing. |
@patmmccann Sorry, if you get a chance, a re-review would be very appreciated. The PR has been updated and tests are now passing 🙏 |
* Add FreePass Bid Adapter * Add note about FreePass IdSystem * Unrequire userId * Add test flag * Update official maintainer email * Update official bidder service URL * No credentials Client does not need to send credentials * Add md code type Trigger ci * Replace double with single quotes * Append js to import * Build mock request in local scope * Update maintainer email
* Add FreePass Bid Adapter * Add note about FreePass IdSystem * Unrequire userId * Add test flag * Update official maintainer email * Update official bidder service URL * No credentials Client does not need to send credentials * Add md code type Trigger ci * Replace double with single quotes * Append js to import * Build mock request in local scope * Update maintainer email
Type of change
Description of change
New Bid Adapter from FreePass.
Please the ff parameters to validate the adapter:
Contact maintainer at [email protected]
Other information
Docs: prebid/prebid.github.io#4495
Testing with hello_world
Related discussion: #9712
Due to IP restriction we have prepared a US-based mock server to respond to external requests at
172.104.192.122
. If this is not acceptable, please advice and we will try to prepare for external access to actual bidder service.To test, please add the ff to your
/etc/hosts