Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttd bid adapter: pass on all of user/app/ortb2imp for first party data support, default imp.secure #9892

Merged
merged 5 commits into from
May 6, 2023
Merged

ttd bid adapter: pass on all of user/app/ortb2imp for first party data support, default imp.secure #9892

merged 5 commits into from
May 6, 2023

Conversation

khang-vu-ttd
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Pass on all members in user/app/site for first party support
Default imp.secure = 1 if not set

Other information

@julian-burger-ttd

@patmmccann patmmccann self-requested a review May 3, 2023 20:38
@patmmccann patmmccann self-assigned this May 3, 2023
@patmmccann
Copy link
Collaborator

why not take pmp?

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not take PMP and device object also?

modules/ttdBidAdapter.js Outdated Show resolved Hide resolved
@patmmccann
Copy link
Collaborator

Thanks!!

@patmmccann patmmccann merged commit 386c95a into prebid:master May 6, 2023
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
…a support, default imp.secure (prebid#9892)

* pass on user, app, imp

* cosmetic changes

* get secure from the right place

* don't need to import mergeDeep

* add pmp and device first party data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants