Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use of a custom line-item template instead of package default #65

Closed
dshore opened this issue Apr 28, 2021 · 0 comments
Closed
Labels
enhancement New feature or request in DEV Resolution is in DEV release

Comments

@dshore
Copy link
Collaborator

dshore commented Apr 28, 2021

Description

On occasions that require additional attribute detailing on the line item it would be nice to be able to specify a custom template.

Example use case of adding geoTargeting by modifying the line item template since it is not supported in the configuration; one could add the below as a custom template:

. . .

targeting:
  geoTargeting:
    excludedLocations:
      - id: 2840
        displayName: "United States"

. . .

AC

Add a CLI option to specify a custom line item template to use instead of the package default. E.g:

$ line_item_manager show template > exclude_US_template.yml
# edit exclude_US_template.yml adding above targeting to exclude the United States
$ line_item_manager create my_config.yml --single-order --template exclude_US_template.yml
@dshore dshore added the enhancement New feature or request label Apr 29, 2021
dshore added a commit that referenced this issue May 4, 2021
Custom line-item template instead of package default (#65)
@dshore dshore added the in DEV Resolution is in DEV release label May 4, 2021
@dshore dshore closed this as completed May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in DEV Resolution is in DEV release
Projects
None yet
Development

No branches or pull requests

1 participant