Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectAd: Bidder params update #3715

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

rtuschkany
Copy link
Contributor

Accept multiple networkid and siteid types to fix prebid/Prebid.js#6361

Accept multiple networkid and siteid types to fix prebid/Prebid.js#6361
@rtuschkany rtuschkany changed the title ConenctAd Adapter Update ConnectAd Adapter Update Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b9ff00e

connectad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:29:	MakeRequests		95.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:73:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:107:	preprocess		100.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:141:	addImpInfo		100.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:151:	addHeaderIfNonEmpty	100.0%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:157:	unpackImpExt		88.9%
github.com/prebid/prebid-server/v2/adapters/connectad/connectad.go:181:	buildImpBanner		100.0%
total:									(statements)		97.6%

@bsardo bsardo changed the title ConnectAd Adapter Update ConnectAd: Bidder params update Jun 4, 2024
userMacro: ""
# connectad appends the user id to end of the redirect url and does not utilize a macro
iframe:
url: "https://sync.connectad.io/iFrameSyncer?gdpr={{.GDPR}}&consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&cb={{.RedirectURL}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-06-17 at 1 13 43 PM

Getting 403 for userSync. Please check.

https://sync.connectad.io/iFrameSyncer?gdpr=&consent=&us_privacy=&gpp=&gpp_sid=&cb=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dconnectad%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also getting 403

Copy link
Contributor Author

@rtuschkany rtuschkany Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you trying to access that url via VPN? Where are you located? both sync urls are up and running
Bildschirmfoto 2024-06-17 um 15 05 30

Copy link
Contributor

@gargcreation1992 gargcreation1992 Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are trying from India. @rtuschkany

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you are not calling it from a suspicious, banned, or datacenter ip, there will be no issue @gargcreation1992

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked again. Worked fine this time.

@gargcreation1992 gargcreation1992 merged commit 382f793 into prebid:master Jul 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve client-side footprint for server-side adapters
3 participants