New Adapter: ResetDigital #3766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to include `required` if its empty _Originally posted by @onkarvhanumante in prebid#3452 (comment)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| func getBidType(imp openrtb2.Imp) (openrtb_ext.BidType, error) { | ||
| if imp.Banner != nil { |
There was a problem hiding this comment.
Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner, nil. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
There was a problem hiding this comment.
Implemented as suggested
could you point out or link where MType changes are implemented?
There was a problem hiding this comment.
Sorry, it was addressed on the point that we support only single format bids, so we could assume the anti pattern. Anyway, it would be more advisable to change to the normal pattern?
There was a problem hiding this comment.
Anyway, it would be more advisable to change to the normal pattern?
Prebid team recommends using MType field. But if it's not doable then current change suffices single format bid. @bruno-siira should mention in Bidder docs that adapter expects only single format bids in the incoming request
There was a problem hiding this comment.
When we're talking about the Bidder Docs what is this file exacly @onkarvhanumante
There was a problem hiding this comment.
Code coverage summaryNote:
resetdigitalRefer here for heat map coverage report |
Implementation of suggestions
Code coverage summaryNote:
resetdigitalRefer here for heat map coverage report |
Code coverage summaryNote:
resetdigitalRefer here for heat map coverage report |
Comment on lines
93
to
97
| if request.Site == nil { | ||
| return "" | ||
| } | ||
|
|
||
| return request.Site.Domain |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
Comment on lines
101
to
103
| if len(request.Cur) == 0 { | ||
| return "USD" | ||
| } |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
Comment on lines
+118
to
+119
| errors = append(errors, err) | ||
| continue |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
Comment on lines
+124
to
+125
| errors = append(errors, err) | ||
| continue |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
| resetDigitalRequestData.Imps[0].MediaTypes.Banner.Sizes = append(resetDigitalRequestData.Imps[0].MediaTypes.Banner.Sizes, []int64{imp.Banner.Format[0].W, imp.Banner.Format[0].H}) | ||
| } | ||
| if bidType == openrtb_ext.BidTypeVideo { | ||
| resetDigitalRequestData.Imps[0].MediaTypes.Video.Sizes = append(resetDigitalRequestData.Imps[0].MediaTypes.Banner.Sizes, []int64{*imp.Video.W, *imp.Video.H}) |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
| } | ||
|
|
||
| func (a *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) { | ||
| if response.StatusCode == http.StatusNoContent || response.StatusCode == http.StatusBadRequest || response.StatusCode != http.StatusOK { |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
| bidMap := bidData.(map[string]interface{}) | ||
| bid := getBidFromResponse(bidMap) | ||
| if bid == nil { | ||
| continue |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
|
|
||
| bidTypes, err := getBidTypes(internalRequest.Imp[0]) | ||
| if err != nil { | ||
| return nil, []error{err} |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
| } | ||
| } | ||
|
|
||
| if bid.Price == 0 { |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
| if value, ok := requestData["cpm"].(float64); ok { | ||
| return value | ||
| } | ||
| return 0.0 // Default value if "cpm" doesn't exist or is not a float64 |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
Comment on lines
+272
to
+281
| } | ||
| if imp.Video != nil { | ||
| bidTypes = append(bidTypes, openrtb_ext.BidTypeVideo) | ||
| } | ||
| if imp.Audio != nil { | ||
| bidTypes = append(bidTypes, openrtb_ext.BidTypeAudio) | ||
| } | ||
| if len(bidTypes) == 0 { | ||
| return nil, fmt.Errorf("failed to find matching imp for bid %s", imp.ID) | ||
| } |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
Comment on lines
+259
to
+264
| return openrtb_ext.BidTypeVideo, nil | ||
| } else if imp.Audio != nil { | ||
| return openrtb_ext.BidTypeAudio, nil | ||
| } | ||
|
|
||
| return "", fmt.Errorf("failed to find matching imp for bid %s", imp.ID) |
There was a problem hiding this comment.
code path is not covered. should add json tests to improve coverage
|
@bruno-siira please add or link bidder docs PR for adapter. |
Code coverage summaryNote:
resetdigitalRefer here for heat map coverage report |
Code coverage summaryNote:
resetdigitalRefer here for heat map coverage report |
…xcluded. Can be rewritten as below:
Code coverage summaryNote:
resetdigitalRefer here for heat map coverage report |
Comment on lines
181
to
187
| if response.StatusCode == http.StatusNoContent || response.StatusCode == http.StatusBadRequest || response.StatusCode != http.StatusOK { | ||
| if adapters.IsResponseStatusCodeNoContent(response) { | ||
| return nil, nil | ||
| } | ||
|
|
||
| if err := adapters.CheckResponseStatusCodeForErrors(response); err != nil { | ||
| return nil, []error{err} | ||
| } |
There was a problem hiding this comment.
should add json exemplary tests for above code path
Code coverage summaryNote:
resetdigitalRefer here for heat map coverage report |
Comment on lines
+16
to
+18
| // MaximumBids is the maximum number of bids that can be returned by this adapter. | ||
| const maxBids = 1 | ||
|
|
There was a problem hiding this comment.
maxBids is unused. can remove this var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new adapter for Reset Digital to the Prebid Server (Go version). The adapter enables Prebid Server to communicate with Reset Digital for real-time advertising auctions.
Changes:
Added the Reset Digital adapter in adapters/resetdigital/.
Implemented necessary methods for the adapter.
Added unit tests for the adapter in adapters/resetdigital/resetdigital_test.go.
Updated the documentation to include the configuration for the Reset Digital adapter.
Testing:
Unit tests have been written and verified to ensure the adapter works correctly.
Manual testing has been performed to verify the integration with Reset Digital.
Notes:
This system is based on single bid, so it's based on that premise.
Related Issues: