Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: Escalax #3798

Merged
merged 4 commits into from
Aug 30, 2024
Merged

New Adapter: Escalax #3798

merged 4 commits into from
Aug 30, 2024

Conversation

escalax
Copy link
Contributor

@escalax escalax commented Jul 8, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c620e3f

escalax

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:56:	MakeRequests			81.8%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:83:	getImpressionExt		100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:100:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:105:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:121:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:162:	determineImpressionMediaType	90.0%
total:									(statements)			95.8%

@escalax escalax mentioned this pull request Jul 8, 2024
Merged
8 tasks
@escalax escalax marked this pull request as ready for review July 8, 2024 12:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6c28566

escalax

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:56:	MakeRequests			81.8%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:83:	getImpressionExt		100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:100:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:105:	checkResponseStatusCodes	100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:121:	MakeBids			100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:162:	determineImpressionMediaType	100.0%
total:									(statements)			97.0%

gargcreation1992
gargcreation1992 reviewed Aug 6, 2024
View reviewed changes
static/bidder-info/escalax.yaml Show resolved Hide resolved
adapters/escalax/escalax.go Show resolved Hide resolved
adapters/escalax/escalax.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1856142

escalax

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:56:	MakeRequests			81.8%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:83:	getImpressionExt		100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:100:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:105:	MakeBids			95.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:149:	determineImpressionMediaType	100.0%
total:									(statements)			95.2%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 25f3959

escalax

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:21:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:33:	getHeaders			100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:56:	MakeRequests			81.8%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:83:	getImpressionExt		100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:100:	buildEndpointURL		100.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:105:	MakeBids			95.0%
github.com/prebid/prebid-server/v2/adapters/escalax/escalax.go:149:	determineImpressionMediaType	100.0%
total:									(statements)			95.2%

@przemkaczmarek przemkaczmarek self-requested a review August 22, 2024 13:25
@bsardo bsardo merged commit 2e2b49f into prebid:master Aug 30, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Aug 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

@przemkaczmarek przemkaczmarek przemkaczmarek approved these changes

Assignees

@gargcreation1992 gargcreation1992

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@escalax @gargcreation1992 @przemkaczmarek @bsardo @Sonali-More-Xandr