Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retailspot documentation #4490

Merged
merged 4 commits into from
Jun 20, 2023
Merged

add retailspot documentation #4490

merged 4 commits into from
Jun 20, 2023

Conversation

rs-guian
Copy link
Contributor

@rs-guian rs-guian commented Apr 18, 2023

🏷 Type of documentation

  • [*] new bid adapter

Related pull requests in prebid.js:

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 7384358
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/649003746e192d0008045298
😎 Deploy Preview https://deploy-preview-4490--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rs-guian - if you're going to claim GDPR support, you almost certainly require a GVL ID. Also, please supply the other metadata fields:

coppa_supported:
userIds:
safeframes_ok:
deals_supported:
fpd_supported:
ortb_blocking_supported:
gvl_id:
multiformat_supported:

@rs-guian
Copy link
Contributor Author

I'll add those.

We haven't got a GVL id though. We claim to support GDPR as sellers: Transmitting user consent information to buyers. We don't need to request user consent ourselves as we won't read/store nor use user cookie informations. I will update our GVL ID accordingly if this should change.

In the meantime would you mind having a look at our test page where no ad is never shown whereas bid response is always filled up ?
Basic Prebid.js Example with Retailspot
Just in case you quickly see something we miss, thank you.

@fowler446
Copy link
Contributor

Screenshot 2023-05-18 at 2 41 07 PM

Test page is looking good 👍 @rs-guian

@rs-guian
Copy link
Contributor Author

Everything looks good.
Adapter has been merged into prebid.js

prebid/Prebid.js#9824

thank you

pbs: false
media_types: banner, video
biddercode: retailspot
gdpr_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Bret mentioned, if you claim gdpr_support your must provide a gvl_id here.

gvl_id: <your id here>

@muuki88
Copy link
Contributor

muuki88 commented Jun 1, 2023

@rs-guian either add a gvl_id or set gdpr_support to false. Then this is good to merge.

@muuki88
Copy link
Contributor

muuki88 commented Jun 15, 2023

We haven't got a GVL id though. We claim to support GDPR as sellers: Transmitting user consent information to buyers. We don't need to request user consent ourselves as we won't read/store nor use user cookie informations

Thanks for your patience @rs-guian We'll discuss the GVL_ID topic today in the docs committee.

@bretg
Copy link
Contributor

bretg commented Jun 15, 2023

We discussed this topic @rs-guian . You have to set the gdpr_supported flag to false.

  • Prebid cannot trust any entity with user data even through they claim not to look at it or touch it.
  • Publishers rely on Prebid as part of their compliance toolset and being able to take action on GDPR consent rules is a part of that. Prebid cannot take action without mapping a user's vendor consent to the specific module. You must have a GVLID for that mapping.
  • No one else has tried to claim GDPR support without having a GVLID
  • You can attempt to convince your publisher clients that they should make an 'exception' and exempt you from Prebid's GDPR processing activities.

But in the end, from a Prebid perspective, you do not support GDPR if you don't have a GVLID.

@rs-guian
Copy link
Contributor Author

Got it, thanks a lot for discussing it and giving me this well-argued answer.

@rs-guian
Copy link
Contributor Author

Done. We'll claim our GDPR ID and update the value soon.

Thank you again.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bretg
Copy link
Contributor

bretg commented Jun 20, 2023

Released with PBJS 7.49. Merging.

@bretg bretg merged commit bf806f8 into prebid:master Jun 20, 2023
4 checks passed
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* add retailspot documentation

* add support information

* change gdpr support to false for now

---------

Co-authored-by: guiann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants