Kulturemedia adapter #4797
Merged
Kulturemedia adapter #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@ChrisHuie Our adapter was merged last week. prebid/Prebid.js#10358 |
|
@patmmccann Any info when this will be merged and why is it taking so long? |
7 tasks
7 tasks
|
@ChrisHuie @patmmccann @ncolletti |
|
FYI looks like this is already merged in JS: prebid/Prebid.js#10358 |
mkendall07
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
[X ] Does this change affect user-facing APIs or examples documented on http://prebid.org?
[X ] Other
Description of change
Subject: Rebranding: Changing Adapter Name from kulturemedia to dxkulture
Hi Prebid.js Team,
I hope this message finds you well. I'm reaching out to submit a pull request for the rebranding of our adapter from "kulturemedia" to "dxkulture". This change reflects our new branding and aligns our adapter name more closely with company's identity.
Pull Request Details:
From: kulturemedia
To: dxkulture
Changes Made:
Updated all references to the old adapter name "kulturemedia" to the new name "dxkulture" in the codebase.
Adjusted configuration files to use the new name.
Updated any relevant documentation, comments, and variable names to reflect the rebranding.
Motivation for the Change:
We've recently undergone a rebranding effort, and as part of this process, we're updating our adapter name to "dxkulture". We believe this change will better represent the company and make it easier for users to identify and use our adapter.
Impact Assessment:
This change has been thoroughly tested internally to ensure that it does not introduce any compatibility issues or regressions. All tests have passed successfully, and the adapter continues to work seamlessly with Prebid.js.
Additional Notes:
We have taken care to update any relevant documentation in the repository to reflect the new adapter name. Additionally, the rebranding has been communicated to our existing users to avoid any confusion.
We appreciate your attention to this pull request and your consideration of our rebranding efforts. If there are any further changes or adjustments required, please let us know, and we'll be more than happy to address them promptly.
Thank you for your time and ongoing support.
Best regards,
DXKulture Team