Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lm kiviads #4829

Merged
merged 14 commits into from
Oct 6, 2023
Merged

Lm kiviads #4829

merged 14 commits into from
Oct 6, 2023

Conversation

KiviAds
Copy link
Contributor

@KiviAds KiviAds commented Aug 30, 2023

🏷 Type of documentation

  • new bid adapter

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 11d99ed
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/64f6036fa675670008f53b9f
😎 Deploy Preview https://deploy-preview-4829--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

you can't claim tcfeu_supported without a GVL ID
| `env` | required | Environment name | `kivi-stage` | `string` |
| `pid` | required | unique placement ID | `cs230510321b516f0eb9a10e5913d3b1` | `string` |
| `env` | required | Environment name | `lm_kiviads-stage` | `string` |
| `pid` | required | Unique placement ID | `cs230510321b516f0eb9a10e5913d3b1` | `string` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publishers are unhappy when client-side parameters differ from server-side parameters because it makes their lives more difficult. I've added this adapter to the list at prebid/prebid-server#2654 -- please resolve ASAP.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the inconsistency between client- and server-side parameters doc looks ok.

@bretg
Copy link
Contributor

bretg commented Sep 5, 2023

thanks for the update! You've just helped make Prebid a more consistent experience for publishers. Apprecirated.

@ChrisHuie ChrisHuie merged commit 1e566ef into prebid:master Oct 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants