Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete removed aliases docs #4839

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Delete removed aliases docs #4839

merged 3 commits into from
Oct 12, 2023

Conversation

GeneGenie
Copy link
Contributor

🏷 Type of documentation

  • update bid adapter

📋 Checklist

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 8cad47d
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/65281c5c5399f80009ad2d18
😎 Deploy Preview https://deploy-preview-4839--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for wanting to keep stuff clean @GeneGenie , but we don't normally doc files. Publishers often use very old versions of PBJS where these bidders are still available.

Generally what we do is add a flag enable_download: false to the header so it disappears off the download page, and if possible a pbjs_version_notes: field saying something like "removed in 6.0"

We have an open item to support an "archive" page to get them off the main PBJS bidders page.

However, you're a Prebid veteran, so we might be able to take your word for it if you are absolutely sure that there's no publisher on the planet still using these bidders.

@bretg bretg added the question label Sep 18, 2023
@muuki88
Copy link
Contributor

muuki88 commented Oct 1, 2023

@GeneGenie any update on this?

@GeneGenie
Copy link
Contributor Author

@muuki88 updated, sorry for delays.

@muuki88 muuki88 merged commit e7817cd into prebid:master Oct 12, 2023
5 checks passed
@muuki88
Copy link
Contributor

muuki88 commented Oct 12, 2023

No worries ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants