Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adkernel: removing adliveconnect alias documentation #4856

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

ckbo3hrk
Copy link
Contributor

🏷 Type of documentation

  • update bid adapter

📋 Checklist

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit d61aa65
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6516c936f4604c00087712b3
😎 Deploy Preview https://deploy-preview-4856--prebid-docs-preview.netlify.app/dev-docs/bidders/adliveconnect
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ChrisHuie ChrisHuie self-requested a review September 13, 2023 14:16
@ChrisHuie ChrisHuie self-assigned this Sep 17, 2023
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for wanting to keep stuff clean @ckbo3hrk , but we don't normally doc files. Publishers often use very old versions of PBJS where these bidders are still available.

Generally what we do is add a flag enable_download: false to the header so it disappears off the download page, and if possible a pbjs_version_notes: field saying something like "removed in 6.0"

We have an open item to support an "archive" page to get them off the main PBJS bidders page.

@ckbo3hrk
Copy link
Contributor Author

@bretg added enable_download & pbjs_version_notes fields

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@bretg bretg merged commit 615b5fb into prebid:master Sep 29, 2023
5 checks passed
@ckbo3hrk ckbo3hrk deleted the patch-10 branch September 29, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants