Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utiq ID submodule: Update module name, parameters and contact #4920

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

jkthomas
Copy link
Contributor

@jkthomas jkthomas commented Oct 9, 2023

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit fadfb03
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6697994d5c26700008ea8082
😎 Deploy Preview https://deploy-preview-4920--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ChrisHuie
Copy link
Contributor

@jkthomas we reverted this pr as it needs to be included with the next major release

@muuki88
Copy link
Contributor

muuki88 commented Oct 30, 2023

Reverted in prebid/Prebid.js#10606

@muuki88
Copy link
Contributor

muuki88 commented Jun 16, 2024

@jkthomas prebid 9 has been released and this is ready to merge. However there are some conflicts that need to be resolved first.

@jkthomas
Copy link
Contributor Author

jkthomas commented Jul 16, 2024

We made update to the docs and resolved the conflict, but it seems that the initialization in Netlify failed, even though the build was successful. It yields:

1:41:25 PM: Failed during stage 'Install dependencies': dependency_installation script returned non-zero exit code: 1
1:41:25 PM: Resolving dependencies....
1:41:25 PM: ffi-1.17.0-x86_64-linux-musl requires rubygems version >= 3.3.22, which is
1:41:25 PM: incompatible with the current version, 3.1.6
1:41:25 PM: Error during gem install
1:41:25 PM: Failing build: Failed to install dependencies

I cannot re-run it and it looks like some dependency issue in the server. Is that right @muuki88?

@muuki88
Copy link
Contributor

muuki88 commented Jul 16, 2024

@jkthomas seems that there are still merge conflicts. That's the reasons the build fails.

@muuki88
Copy link
Contributor

muuki88 commented Jul 16, 2024

I cannot re-run it and it looks like some dependency issue in the server. Is that right

I recommend using github codespaces. See https://github.com/prebid/prebid.github.io/blob/master/guide.md#getting-started

@jkthomas
Copy link
Contributor Author

All should be fine now, thanks for tips @muuki88 !

Some things that confused me a bit:

  • the build failed due to the conflict, but the netlify pipeline has shown it as an error with a dependency during initialization, which didn't explain the issue and seemed like an internal server problem
  • there were conflicts in the PR even that it didn't show with the local merge or rebase (that's on me, interesting case though)

@muuki88 muuki88 merged commit 1a31c48 into prebid:master Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants