You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51Degrees module sets the following fields of the device object: make, model, os, osv, h, w, ppi, pxratio - interested bidder adapters may use these fields as needed. In addition the module sets device.ext.fiftyonedegrees_deviceId to a permanent device ID which can be rapidly looked up in on premise data exposing over 250 properties including the device age, chip set, codec support, and price, operating system and app/browser versions, age, and embedded features.
🏷 Type of documentation
new feature
📋 Checklist
Related pull requests in prebid-server and prebid-server-java are linked:
Hi @bretg thank you for providing this thorough review. I've incorporated the changes according to the comments, except for one re: converting the list of parameters into the table - I've checked the preview and indentation seems to reflect the nesting of parameters quite well. Please let us know any further changes needed when you have a chance. Thanks.
Thanks @justadreamer - unfortunately preview is now broken due to an environment issue. Could you update the Gemfile in this PR to match #5384 ? Then preview would work so I could review the table formatting, which is a common area of problems.
Hi @bretg, I've merged the latest master, the preview has been generated, the doc can be previewed here, also added it to the list of modules in the modules index page, so navigable from there too. Thanks.
Nicely done @justadreamer . FWIW, PBS-Java is soon going to support kebab-case-config and snake_case_config as completely the same. So the extra column in the table should be able to go away.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
51Degrees module enriches an incoming OpenRTB request with 51Degrees Device Data.
51Degrees module sets the following fields of the device object:
make,model,os,osv,h,w,ppi,pxratio- interested bidder adapters may use these fields as needed. In addition the module setsdevice.ext.fiftyonedegrees_deviceIdto a permanent device ID which can be rapidly looked up in on premise data exposing over 250 properties including the device age, chip set, codec support, and price, operating system and app/browser versions, age, and embedded features.🏷 Type of documentation
📋 Checklist