Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EightPod - edit documentation #5493

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

EightPod - edit documentation #5493

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
953a986
fix documentation
GreDiSe Jul 10, 2024
f528086
Merge branch 'master' into eightPod-Bid-Adapter-update-doc
GreDiSe Jul 16, 2024
878feac
Merge branch 'master' into eightPod-Bid-Adapter-update-doc
GreDiSe Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dev-docs/bidders/eightPod.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ gpp_sids: none
schain_supported: false
dchain_supported: false
userId: none
media_types: banner
media_types: banner, video
deals_supported: false
userIds: check with bidder
floors_supported: false
fpd_supported: false
fpd_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry - you can't claim FPD support unless the document has a description of what kind of First Party data. From http://lh.prebid.org:8080/dev-docs/bidder-adaptor.html#submitting-your-adapter "If you support first party data, you must document what exactly is supported and then you may set fpd_supported: true. No default value."

See how other adapters have done this. Site first party data, user first party data, impression-level data, seller-define audience, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GreDiSe - please review this comment

pbjs: true
pbs: false
prebid_member: false
Expand Down