Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ first draft of improved xaxis filtering #250

Merged
merged 12 commits into from
Aug 14, 2023
Merged

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented Jul 30, 2023

What does this PR do:

  • renamed variables to distinguish between layout-(x)axis properties and trace-(x)axis properties (which makes the code more readable)
  • use the Figures _grid_ref variable to construct the mapping between layout-xaxis and trace-xaxis

@jonasvdd jonasvdd requested a review from jvdd July 30, 2023 17:13
@jonasvdd jonasvdd added the enhancement New feature or request label Jul 30, 2023
@jonasvdd jonasvdd marked this pull request as draft July 30, 2023 17:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #250 (3999ec6) into main (b712c67) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   96.87%   96.87%   -0.01%     
==========================================
  Files          14       14              
  Lines        1025     1024       -1     
==========================================
- Hits          993      992       -1     
  Misses         32       32              
Files Changed Coverage Δ
...ler/figure_resampler/figure_resampler_interface.py 99.74% <100.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonasvdd
Copy link
Member Author

jonasvdd commented Aug 6, 2023

Ready for review @jvdd!

@jonasvdd jonasvdd requested review from jvdd and removed request for jvdd August 7, 2023 07:20
@jonasvdd jonasvdd marked this pull request as ready for review August 7, 2023 07:21
@jonasvdd jonasvdd merged commit 574904e into main Aug 14, 2023
13 of 17 checks passed
@jonasvdd jonasvdd deleted the refactor/xaxis_filtering branch August 14, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants