Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address FutureWarning: 'H' is deprecated and will be removed in a future version. Please use 'h' instead of 'H'. #291

Merged

Conversation

t-jakubek
Copy link
Contributor

Noticed this FutureWarning when running plotly-resampler with pandas 2.2.0

<...>\Lib\site-packages\plotly_resampler\figure_resampler\utils.py:177: FutureWarning:
'H' is deprecated and will be removed in a future version. Please use 'h' instead of 'H'.

From what I can see lower case 'h' was required since pandas 1.0, so this change should not break compatibility with older pandas versions.

Let me know if you would prefer for me to open an issue before looking at this PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7612315) 96.42% compared to head (099e958) 96.42%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          14       14           
  Lines        1146     1146           
=======================================
  Hits         1105     1105           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasvdd jonasvdd self-assigned this Feb 1, 2024
Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for contributing this PR @t-jakubek 🤝

@jonasvdd jonasvdd merged commit 1abda53 into predict-idlab:main Feb 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants