Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error when no offline_url is specified with auth type offline #36

Closed
preslavmihaylov opened this issue Aug 7, 2020 · 0 comments · Fixed by #49
Closed

Return error when no offline_url is specified with auth type offline #36

preslavmihaylov opened this issue Aug 7, 2020 · 0 comments · Fixed by #49
Labels
bug Something isn't working

Comments

@preslavmihaylov
Copy link
Owner

When the auth type is offline, there should also be an offline_url field in the configuration specified.

If such is not specified, no error is shown, instead, the application works but shows:

Please go to  and paste the offline token below:
Token:
@preslavmihaylov preslavmihaylov added the bug Something isn't working label Aug 7, 2020
@preslavmihaylov preslavmihaylov changed the title Return error when no offline_url is specified with auth type offlien Return error when no offline_url is specified with auth type offline Aug 7, 2020
@preslavmihaylov preslavmihaylov mentioned this issue Aug 24, 2020
Closed
@mehdy mehdy mentioned this issue Aug 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add offline url validation when auth type is offline mehdy/todocheck
1 participant
@preslavmihaylov