Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic when someone has passed an unsupported issue tracker #44

Closed
preslavmihaylov opened this issue Aug 19, 2020 · 3 comments · Fixed by #46
Closed

Don't panic when someone has passed an unsupported issue tracker #44

preslavmihaylov opened this issue Aug 19, 2020 · 3 comments · Fixed by #46
Labels
bug Something isn't working enhancement New feature or request

Comments

@preslavmihaylov
Copy link
Owner

When someone specifies an unsupported issue tracker, a non-user friendly panic occurs. See #43

Instead, validate the issue tracker & configuration beforehand & print a more user-friendly error message.
@preslavmihaylov preslavmihaylov added enhancement New feature or request bug Something isn't working labels Aug 19, 2020
@mehdy
Copy link
Collaborator

mehdy commented Aug 24, 2020

I'm thinking of a Validate() method for the Local struct for this issue. We could call it right after creating a new local config and make sure we have the right config.
Let me know what you think.

@preslavmihaylov
Copy link
Owner Author

Yes, that sounds good. We can encapsulate all similar config validations there. Including #36

@mehdy
Copy link
Collaborator

mehdy commented Aug 24, 2020

Yes, that sounds good. We can encapsulate all similar config validations there. Including #36

Exactly. So I'll be working on this.

mehdy added a commit to mehdy/todocheck that referenced this issue Aug 25, 2020
@mehdy
Add configuration validation beforehand (preslavmihaylov#44)
64f98b9 
Signed-off-by: Mehdy Khoshnoody <[email protected]>
@mehdy mehdy mentioned this issue Aug 25, 2020
Merged
mehdy added a commit to mehdy/todocheck that referenced this issue Aug 26, 2020
@mehdy
Add configuration validation beforehand (preslavmihaylov#44)
0ce4d8c 
Signed-off-by: Mehdy Khoshnoody <[email protected]>
mehdy added a commit to mehdy/todocheck that referenced this issue Aug 26, 2020
@mehdy
Add test for invalid issue tracker scenario (preslavmihaylov#44)
7d1c463 
Signed-off-by: Mehdy Khoshnoody <[email protected]>
preslavmihaylov pushed a commit that referenced this issue Aug 27, 2020
@mehdy
Add configuration validation beforehand (#46)
b109a2b 
* Add configuration validation beforehand (#44)

Signed-off-by: Mehdy Khoshnoody <[email protected]>

* Add test for invalid issue tracker scenario (#44)

Signed-off-by: Mehdy Khoshnoody <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add configuration validation beforehand mehdy/todocheck
2 participants
@mehdy @preslavmihaylov