Show an error if auth type is incorrect

[preslavmihaylov]

Here's the error I get when the provided auth type in .todocheck.yaml is incorrect:

This happens because there is a check for it in one of the components using the config. It would be more appropriate to validate against this in the config.Validate function instead and show an error message to the user in a normal fashion, rather than relying on a panic, which happens afterwards.

[akk5597]

Would the solution be to call authmanager.AcquireToken in config.Validate, and replace the panic with an error saying that the auth token type is unknown?

Edit: That would not work as that would be an import cycle

[preslavmihaylov]

I think a good approach would be to make a function like this (taken from here):

func (lt LeaveType) IsValid() error {
    switch lt {
    case AnnualLeave, Sick, BankHoliday, Other:
        return nil
    }
    return errors.New("Invalid leave type")
}

This function should be in the same file as the enum declarations to avoid someone creating a new enum in the future without upgrading this func.

Using AcquireToken to validate is not a good idea, IMO, because it is not meant to be used for validation, but rather, for acquiring a token as the name states.

[zen37]

It would be more appropriate to validate against this in the config.Validate function instead

Where is the config.Validate function? I could not find it.

[preslavmihaylov]

todocheck/config/config.go

Line 145 in ce4a242

func (l *Local) Validate() []error {

[zen37]

sorry, I didn't know of this convention, fileName.functionName and it is so logical.

[preslavmihaylov]

Closed by #84