Add support for all Kotlin files #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preslavmihaylov
requested changes
Aug 10, 2021
| @@ -591,7 +591,7 @@ func TestGroovyTodos(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // Also tests Rust TODOs as rust uses the same comment syntax | |||
| // Also tests Rust and Kotlin TODOs as they use the same comment syntax | |||
There was a problem hiding this comment.
can you:
- include a file in
testing/scenarios/swift/which is a kotlin source file & include todo err scenarios for it as well? - Could you do the same for Rust as it seems to have been missed?
There was a problem hiding this comment.
The changes requested have now been included @preslavmihaylov
preslavmihaylov
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155.
Reuses the standard comment matcher used for Rust and Swift, which supports single-, multiline comments, as well as nested comments.