Added unit tests for fetcher, checker and matchers packages #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preslavmihaylov
previously approved these changes
Aug 6, 2022
|
@eisandbar looks like there are some lint issues. Could you check em out. After that, we're good to go |
Hi! I fixed the lint errors and running golangci-lint v1.48.0 on my computer shows no errors, but the lint action still fails on the same files. |
|
@eisandbar could you rebase? The lint issue should be resolved now |
Added unit tests for the 3 functions in matchers.go
Changed checker to accept interface of type Fetcher for easier mocking. Added tests for all the possible errors that could happen in Check
Refactored fetcher to use fetcher.sendRequest instead of hclient.Do for easier testing. Added tests for fetch function for all possible errors
Fixed lint issues associated with return statements
|
@preslavmihaylov Yes, no problem |
preslavmihaylov
approved these changes
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As issue #173 is pretty broad I decided to first work on part of it.
Did slight refactoring in fetcher.go for easier testing and added tests for all possible errors in Fetch()
Checker now accepts interface of type Fetcher for easier mocking. Added tests for all possible errors in Check()
Added tests for all 3 functions in matchers.go. Tests use supportedMatchers for test cases so updating supportedMatchers should update tests.
go test -cover now shows 100% for these 3 files