Fix #3515/#3516: Calendar fix controlled value change #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure why previously it cared whether the popup was visible or not? |
melloware
force-pushed
the
3515-calendar-value-does-not-update-on-external-change
branch
from
7c3f611
to
20fd559
Compare
melloware
changed the title
melloware
deleted the
3515-calendar-value-does-not-update-on-external-change
branch
yrios-cdd
reviewed
Nov 7, 2022
| if (!visible && newDate) { | ||
| validateDate(newDate); | ||
| setViewDateState(newDate); | ||
| setCurrentMonth(newDate.getMonth()); |
There was a problem hiding this comment.
@melloware When the selectionMode property of the Calendar component is range the value of the newDate variable is an array and the function getMonth() is not available.
There was a problem hiding this comment.
is already fixed check master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fix #3515: Calendar fix controlled value change
Fix #3516: Inconsistent behaviour around viewDate and changed value.