Fix(ColorPicker): apply s and b of previous hsb to hsbValue

[KumJungMin]

Defect Fixes

• fix ColorPicker: the selected color is change to hug line color #6787

modified list

1. pageYOffset is deprecated, So I changed pageYOffset to scrollY

// before
const top = hueViewRef.current.getBoundingClientRect().top + (window.pageYOffset || document.documentElement.scrollTop || document.body.scrollTop || 0);

// after
const top = hueViewRef.current.getBoundingClientRect().top + (window.scrollY || document.documentElement.scrollTop || document.body.scrollTop || 0);

2. check undefined in Y position.

const getPositionY = (event) => {
  if (event.pageY !== undefined) return event.pageY;
  else if (event.touches !== undefined) return event.touches[0].pageY;
  else return 0;
};

3. apply s and b of previous hsb to this.hsbValue

// before
hsbValue.current = validateHSB({
    h: Math.floor((360 * (150 - Math.max(0, Math.min(150, (event.pageY || event.changedTouches[0].pageY) - top)))) / 150),
    s: 100, // this!
    b: 100, // this!
});

// after
hsbValue.current = validateHSB({
    h: hue,
    s: hsbValue.current.s, // changed code
    b: hsbValue.current.b // changed code
});

result

2024-06-24.9.21.55.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
primereact	⬜️ Ignored (Inspect)	Visit Preview		Jun 25, 2024 0:05am
primereact-v9	⬜️ Ignored (Inspect)	Visit Preview		Jun 25, 2024 0:05am

[melloware]

should this be touches or changedTouches ?

[KumJungMin]

OOPS!! you're right
thank you for comment :) (63881b0)