Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dialog): prevent unblock of scroll when even one dialog is open #5854

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(Dialog): prevent unblock of scroll when even one dialog is open #5854

wants to merge 3 commits into from
+17 −2

Conversation

KumJungMin
Copy link
Contributor

@KumJungMin KumJungMin commented Jun 8, 2024 •
edited
Loading

Defect Fixes

Commit description
99441eb Fix the issue where the scroll width is redundantly removed from the content width when an additional dialog is opened.
bfb4690 Keep the scroll disabled as long as at least one dialog is open.

@vercel Vercel
Copy link

vercel bot commented Jun 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jun 8, 2024 0:36am
primevue-v4 ⬜️ Ignored (Inspect) Visit Preview Jun 8, 2024 0:36am

@KumJungMin KumJungMin changed the title fix: block duplicate block content #4563 fix: prevent unblock of scroll when even one modal is open Jun 8, 2024
@KumJungMin KumJungMin changed the title fix: prevent unblock of scroll when even one modal is open fix: prevent unblock of scroll when even one modal is open #4563 Jun 8, 2024
@KumJungMin KumJungMin changed the title fix: prevent unblock of scroll when even one modal is open #4563 fix: prevent unblock of scroll when even one dialog is open #4563 Jun 8, 2024
@KumJungMin KumJungMin changed the title fix: prevent unblock of scroll when even one dialog is open #4563 fix: prevent unblock of scroll when even one dialog is open 4563 Jun 10, 2024
@KumJungMin KumJungMin changed the title fix: prevent unblock of scroll when even one dialog is open 4563 fix: prevent unblock of scroll when even one dialog is open Jun 10, 2024
@KumJungMin KumJungMin changed the title fix: prevent unblock of scroll when even one dialog is open fix(Dialog): prevent unblock of scroll when even one dialog is open Jun 10, 2024
@tugcekucukoglu tugcekucukoglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic Dialog: Component gets non-modal if nested Dialog closes.
2 participants
@KumJungMin @tugcekucukoglu