Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Calendar): keep the overlay open when event triggered from panel #5858

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(Calendar): keep the overlay open when event triggered from panel #5858

wants to merge 2 commits into from
+4 −1

Conversation

KumJungMin
Copy link
Contributor

Defect Fixes

how to resolve

  • In panelMenuList.vue, whether a specific element is a panel is determined by the following code.

primevue/components/lib/panelmenu/PanelMenuList.vue

Line 235 in 38a334a

const panel = event.currentTarget.closest('[data-pc-section="panel"]');

  • The dropdown list appears in the body area, so it's difficult to know if the dropdown belongs to the calendar using the usual methods.
  • Therefore, we check if the event occurred within the panel, and if the event occurred within the panel, we keep the overlay open.

@vercel Vercel
Copy link

vercel bot commented Jun 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:55am
primevue-v4 ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 2:55am

@KumJungMin KumJungMin changed the title fix: keep the overlay open when event triggered from panel fix: keep the overlay open when event triggered from panel #4240 Jun 10, 2024
@KumJungMin KumJungMin changed the title fix: keep the overlay open when event triggered from panel #4240 fix: keep the overlay open when event triggered from panel Jun 10, 2024
@KumJungMin KumJungMin changed the title fix: keep the overlay open when event triggered from panel fix(Calendar): keep the overlay open when event triggered from panel Jun 10, 2024
@tugcekucukoglu tugcekucukoglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calendar: Dropdown in #header or #footer slot not selectable.
2 participants
@KumJungMin @tugcekucukoglu