Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to a ES Module (blocked on next-major) #2354

Closed
wants to merge 12 commits into from
Closed

Convert to a ES Module (blocked on next-major) #2354

wants to merge 12 commits into from

Conversation

koddsson
Copy link
Contributor

Describe your changes here.

Convert primer/react to a ES Module.

Screenshots

N/A

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 70f3db0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@koddsson koddsson changed the title Esm Convert to a ES Module Sep 20, 2022
@koddsson koddsson temporarily deployed to github-pages September 20, 2022 10:46 Inactive
@koddsson koddsson temporarily deployed to github-pages September 20, 2022 10:53 Inactive
koddsson
koddsson commented Sep 21, 2022
View reviewed changes
src/__tests__/__snapshots__/themePreval.test.ts.snap Outdated
Comment on lines 4 to 6
"var module = {
exports: {}
};
var exports = module.exports;
// this file was prevaled
// This file needs to be a JavaScript file using CommonJS to be compatible with preval
// Cache bust: 2022-07-25 12:00:00 GMT (This file is cached by our deployment tooling, update this timestamp to rebuild this file)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what preval is so I don't know what to do about this.

koddsson
koddsson commented Sep 21, 2022
View reviewed changes
script/build Outdated Show resolved Hide resolved
@koddsson koddsson marked this pull request as ready for review September 21, 2022 12:28
@koddsson koddsson requested review from a team and rezrah September 21, 2022 12:28
@siddharthkp siddharthkp added react 💓collab a vibrant hub of collaboration labels Sep 27, 2022
@koddsson koddsson temporarily deployed to github-pages September 28, 2022 16:10 Inactive
@koddsson koddsson temporarily deployed to github-pages September 29, 2022 09:41 Inactive
@koddsson koddsson temporarily deployed to github-pages September 29, 2022 10:27 Inactive
@joshblack
Copy link
Member

Hey @koddsson! 👋 Wanted to follow-up on this real quick 👀

It seems like this kind of change will need to be slated to the next major release (v36) and I've added it over to the proposals here: https://github.com/github/primer/issues/1294

As a result, it might be better to revisit it closer to the next major release as I'm not sure if changes can be merged before then.

Hope this makes sense! Let me know if you have any questions

@tallys tallys added the major release breaking changes label Oct 17, 2022
@siddharthkp siddharthkp changed the title Convert to a ES Module Convert to a ES Module (blocked on next-major0 Nov 14, 2022
@siddharthkp siddharthkp changed the title Convert to a ES Module (blocked on next-major0 Convert to a ES Module (blocked on next-major) Nov 14, 2022
@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 13, 2023
@joshblack joshblack removed the Stale label Jan 13, 2023
@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 14, 2023
@lesliecdubs lesliecdubs removed the Stale label Mar 21, 2023
@github-actions
Copy link
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 20, 2023
@joshblack joshblack removed the Stale label May 22, 2023
@joshblack
Copy link
Member

Hi there! 👋 Just wanted to say thanks again for the taking the time to work on this, we picked it up and are building on it over in: #3410

Going to close this out as a result, let me know if you have any questions! Thanks again 🙏

@joshblack joshblack closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rezrah rezrah Awaiting requested review from rezrah

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
💓collab a vibrant hub of collaboration major release breaking changes react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@koddsson @joshblack @siddharthkp @lesliecdubs @tallys