Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionMenu: Make sure event handlers on trigger are called #4648

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

ActionMenu: Make sure event handlers on trigger are called #4648

wants to merge 7 commits into from

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Jun 6, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c821ab6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.72 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 89.99 KB (+0.08% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4648 June 6, 2024 16:40 Inactive
@siddharthkp siddharthkp self-assigned this Jun 18, 2024
@siddharthkp siddharthkp added patch release bug fixes, docs, housekeeping no-breaking-changes: need to test This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jun 18, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4648 June 18, 2024 11:04 Inactive
@siddharthkp siddharthkp changed the title wip: ActionMenu: Make sure event handlers on trigger are called ActionMenu: Make sure event handlers on trigger are called Jun 18, 2024
@siddharthkp siddharthkp mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@siddharthkp siddharthkp

Labels
no-breaking-changes: need to test This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm patch release bug fixes, docs, housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ActionMenu.Button] onClick doesn't function
1 participant
@siddharthkp