Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added className prop to AnchoredOverlay component for custom styling #4752

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Added className prop to AnchoredOverlay component for custom styling #4752

merged 6 commits into from
Jul 23, 2024

Conversation

romanpozdnov
Copy link
Contributor

@romanpozdnov romanpozdnov commented Jul 18, 2024 •
edited by broccolinisoup
Loading

Docs changes related to #4739

Changelog

New

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  1. Verify that the className prop works as expected by adding custom styles to the AnchoredOverlay component.
  2. Ensure that the updated documentation correctly reflects the new className prop.
  3. Check for any potential issues with the className prop in various browsers (Chrome, Firefox, Safari, Edge).
  4. Validate that the component remains SSR compatible with the new className prop.

Merge checklist

@romanpozdnov
Added className prop to AnchoredOverlay component
b7aa886 
### Description:
- Added `className` prop to allow custom styling of the `AnchoredOverlay` component
- This change addresses issue primer#4739
@romanpozdnov
Updated AnchoredOverlay documentation to include className prop
637d4b0 
### Description:
- Added `className` prop to `AnchoredOverlay.docs.json`
@romanpozdnov romanpozdnov requested a review from a team as a code owner July 18, 2024 19:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cfb1c87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@romanpozdnov romanpozdnov mentioned this pull request Jul 18, 2024
Closed
@romanpozdnov romanpozdnov changed the title Add className prop to AnchoredOverlay component for custom styling Added className prop to AnchoredOverlay component for custom styling Jul 18, 2024
@broccolinisoup broccolinisoup requested review from broccolinisoup and removed request for broccolinisoup and langermank July 19, 2024 02:13
broccolinisoup
broccolinisoup reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @romanpozdnov 👋🏻 Thanks for raising this PR! We had another PR for the same issue that is just merged. I'd still love to merge your docs changes! 🙌🏻

Could you please update your branch so that it can only show the docs changes? Let me know if you have any questions 🙌🏻

Thanks for your contribution! We appreciate it very much 🙏🏻

@romanpozdnov
Updated the code according to PR#4741
cfb1c87 
### description:
- the previous PR, which also included the necessary changes: primer#4741
- only the changes to Storybook were kept
@romanpozdnov
Copy link
Contributor Author

romanpozdnov commented Jul 23, 2024 •
edited
Loading

Hello, @broccolinisoup!

I have updated my PR according to the other PR, which also included the necessary code changes. As you suggested, I have left only the changes to the storybook.

I hope I was helpful. I would be happy to assist with other tasks as well, just let me know.

Have a great day!

@broccolinisoup broccolinisoup self-requested a review July 23, 2024 23:07
@broccolinisoup
Copy link
Member

Hi @romanpozdnov 👋🏻 Thanks so much!! All looks good 🎉

Feel free to have a look at our issues and pick if there is anything that interests you! Or reach out if you need any clarification for any of the issues 🙌🏻 Thanks for your contribution!!

@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Jul 23, 2024
@broccolinisoup broccolinisoup added this pull request to the merge queue Jul 23, 2024
Merged via the queue into primer:main with commit dfe6d2f Jul 23, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romanpozdnov @broccolinisoup