Remove chiquito2halo2 function in halo2 backend #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolara
reviewed
Jul 19, 2024
src/plonkish/compiler/mod.rs
Outdated
| pub circuit: Circuit<F>, | ||
| pub assignment_generator: Option<AssignmentGenerator<F, TG>>, | ||
| } | ||
|
|
||
| impl<F: Clone, TG: TraceGenerator<F> + Clone> Clone for PlonkishCompilationResult<F, TG> { |
There was a problem hiding this comment.
@alxkzmn I think you can do an automatic derivation
leolara
reviewed
Jul 19, 2024
src/plonkish/compiler/mod.rs
Outdated
| @@ -54,11 +54,20 @@ pub fn compile< | |||
| } | |||
| } | |||
|
|
|||
| pub struct PlonkishCompilationResult<F, TG> { | |||
| pub struct PlonkishCompilationResult<F: Clone, TG: TraceGenerator<F> + Clone> { | |||
There was a problem hiding this comment.
@alxkzmn I don't think you need to make the generic types Clone here, just in the impl clause that needs that
|
now the halo2 mock prover is not a mock prover, anymore? The changes to python, apart random setup, are just linting? |
|
Yep, it's not a mock prover anymore but I didn't want to rename it everywhere because we're still waiting for privacy-scaling-explorations/halo2#356 to be merged so we can have the "mock prover" again. Those big changes to Poseidon example is because of formatting, the only real change there is passing the |
leolara
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.