Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEID-1311-update-git-pre-commit-hook-documentation #4

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

ketakipai
Copy link
Contributor

@ketakipai ketakipai changed the title updated README DEID-1311-update-git-pre-commit-hook-documentation Nov 29, 2022
README.md Outdated
```
4. Run 'pre-commit install' from inside the git repo where you want to use this hook.
5. Replace 'URL' with the url of where your container is hosted.\
eg. http://localhost:8080/v3/process_text

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eg. http://localhost:8080/v3/process_text
eg. http://localhost:8080/v3/process_text for a container running locally or https://api.private-ai.com/deid/v3/process_text for Private AI's cloud endpoint.


1. Run 'pre-commit install' from inside the git repo where you want to use this hook.
2. Create a file called '.pre-commit-config.yaml' and add the following code to it:
## Installation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prerequisites

This integration requires an endpoint to make requests against. For instructions, please see the installation guide.


<pre>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This integration only works with the 3.0 version of Private AI's container

Copy link

@yaysummeriscoming yaysummeriscoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of small suggestions (and you'll need to make sure that it all looks OK) but apart from that LGTM

@ketakipai ketakipai merged commit 2c903bc into dev Nov 29, 2022
@ketakipai ketakipai deleted the DEID-1311-update-git-pre-commit-hook-documentation branch November 29, 2022 15:37
ketakipai added a commit that referenced this pull request Dec 6, 2022
* added all files

* updated README

* Deid 1284 improve robustness of pii check on off flags (#3)

* fixed bugs with the PII_CHECK flags

* removed local hook

* added suggestion by Guy

* added Guys suggestion and removed local hook

* DEID-1311-update-git-pre-commit-hook-documentation (#4)

* updated README

* did the suggested changes

* Update the way API KEY is read (#2)

* passing path of env file as variable

* remove the unnecessary line from setup.py

* bug fix and updated script to get api key from env file

* updated README

* removed pathlib2 dependency and added stuff to check for relative path

* updated README

* added validation to check if API_KEY is missing

* updated README

* added all dependencies in setup.py, removed from config

* removing unnecessary dependecies from pre-commit-hooks

* updated dependencies

* removed unnecessary fields mentioned in README, tested and confirmed that we need the rest

* updated README

* updated README

* updated README

* updated pre-commit-hooks

* removing args from pre-commit-hooks

* removing entry from pre-commit-config

* updated README to resolve conflicts

* Make compatible with beta2 (#5)

* test

* updated fields to be compatible with beta 2

* removing line added  for debugging

* updated README to contain latest rev

* update README to have new repo

* added link_batch and removed an unused function (#6)

* added link_batch and removed an unused function

* removed test file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants