Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use system projectm-eval (used in vcpkg) #803

Conversation

Blaquewithaq
Copy link
Contributor

This PR introduces a new option to the CMake build system, enabling the utilization of a system-installed version of the ProjectM-Eval library. This modification is essential to adhere to the established guidelines for VCPKG, which stipulate that submodules should function as their own overlay-port.

Option Name: ENABLE_SYSTEM_PROJECTM_EVAL

@Blaquewithaq Blaquewithaq force-pushed the add-option-to-use-system-projectm-eval branch from dee4a70 to 5e58de8 Compare May 3, 2024 03:22
cmake/FindProjectMEval.cmake Outdated Show resolved Hide resolved
vendor/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@Blaquewithaq Blaquewithaq force-pushed the add-option-to-use-system-projectm-eval branch 2 times, most recently from 3b351eb to 281fbb7 Compare May 3, 2024 14:02
Copy link
Member

@kblaschke kblaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the help text if you want, I'm fine with both versions and the other changes 😉
Thanks!

CMakeLists.txt Outdated Show resolved Hide resolved
@Blaquewithaq Blaquewithaq force-pushed the add-option-to-use-system-projectm-eval branch from 281fbb7 to d9b70f6 Compare May 3, 2024 20:01
@Blaquewithaq
Copy link
Contributor Author

Fix the help text if you want, I'm fine with both versions and the other changes 😉 Thanks!

Alright, I made that text modification and pushed the changes, after all have passed, i'll push.

@Blaquewithaq Blaquewithaq force-pushed the add-option-to-use-system-projectm-eval branch from d9b70f6 to f60cd86 Compare May 3, 2024 20:09
@Blaquewithaq Blaquewithaq merged commit f60cd86 into projectM-visualizer:master May 3, 2024
9 checks passed
@Blaquewithaq Blaquewithaq deleted the add-option-to-use-system-projectm-eval branch May 3, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants