Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway API: add support for TCPRoute #5471

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

skriss
Copy link
Member

@skriss skriss commented Jun 12, 2023

Closes #5321.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #5471 (ca6d1b2) into main (4542800) will decrease coverage by 0.16%.
The diff coverage is 68.32%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5471      +/-   ##
==========================================
- Coverage   78.28%   78.12%   -0.16%     
==========================================
  Files         138      139       +1     
  Lines       18648    18833     +185     
==========================================
+ Hits        14599    14714     +115     
- Misses       3768     3835      +67     
- Partials      281      284       +3     
Impacted Files Coverage Δ
internal/controller/tcproute.go 0.00% <0.00%> (ø)
internal/dag/dag.go 98.68% <ø> (ø)
internal/debug/dot.go 49.54% <0.00%> (-5.46%) ⬇️
internal/status/routeconditions.go 48.67% <0.00%> (-5.25%) ⬇️
cmd/contour/serve.go 19.91% <16.66%> (-0.12%) ⬇️
internal/dag/gatewayapi_processor.go 93.84% <88.78%> (-0.51%) ⬇️
internal/dag/accessors.go 86.99% <100.00%> (+0.17%) ⬆️
internal/dag/builder.go 93.33% <100.00%> (+0.35%) ⬆️
internal/dag/cache.go 95.08% <100.00%> (+0.15%) ⬆️
internal/gatewayapi/listeners.go 100.00% <100.00%> (ø)
... and 4 more

@skriss skriss force-pushed the pr-gwapi-tcproute branch 2 times, most recently from aadadc9 to 0c6b21f Compare June 12, 2023 22:58
@skriss skriss added the release-note/minor A minor change that needs about a paragraph of explanation in the release notes. label Jun 13, 2023
@skriss skriss force-pushed the pr-gwapi-tcproute branch 2 times, most recently from 9b1d342 to 67880f6 Compare June 13, 2023 13:49
@skriss skriss marked this pull request as ready for review June 13, 2023 13:50
@skriss skriss requested a review from a team as a code owner June 13, 2023 13:50
@skriss skriss requested review from tsaarni and sunjayBhatia and removed request for a team June 13, 2023 13:50
@skriss skriss force-pushed the pr-gwapi-tcproute branch 3 times, most recently from 2aae894 to af42608 Compare June 14, 2023 19:00
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! basically we add a new property on a listener separate from virtualhost since with plain tcp we can't do any sni/hostname routing and set up the tcp proxy filter accordingly 👍🏽

wdyt about an e2e test for this? might be a while until there is a relevant one in upstream

internal/k8s/kind.go Show resolved Hide resolved
internal/k8s/helpers.go Show resolved Hide resolved
@skriss
Copy link
Member Author

skriss commented Jun 14, 2023

wdyt about an e2e test for this? might be a while until there is a relevant one in upstream

I added a basic one, I should probably also circle back and add one to the provisioner suite for a Gateway with many Listener ports, and can include a TCP listener as part of that, just to exercise the non-standard ports. Will do that in a separate PR.

Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss merged commit 216f362 into projectcontour:main Jun 15, 2023
26 of 27 checks passed
@skriss skriss deleted the pr-gwapi-tcproute branch June 15, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor A minor change that needs about a paragraph of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway API: support TCPRoute
2 participants