Create Helm chart for Nessie #1677
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1677 +/- ##
=========================================
Coverage 79.74% 79.74%
Complexity 2399 2399
=========================================
Files 297 297
Lines 14117 14117
Branches 1050 1050
=========================================
Hits 11258 11258
Misses 2349 2349
Partials 510 510
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
servers/quarkus-server/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
| # runAsNonRoot: true | ||
| # runAsUser: 1000 | ||
|
|
||
| service: |
There was a problem hiding this comment.
An example of configuring this with a real ingest would be good for the docs
There was a problem hiding this comment.
I'll try and add a script that generates some data/commits and update the docs in a separate PR
There was a problem hiding this comment.
by ingest I meant nginx and possibly ssl as opposed to ingesting data w/ nessie
servers/quarkus-server/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
k8s
branch
2 times, most recently
from
4ab9465
to
270000c
Compare
| - name: AWS_REGION | ||
| value: {{ .Values.dynamodb.region }} | ||
| {{- end }} | ||
| - name: AWS_ACCESS_KEY_ID |
There was a problem hiding this comment.
will these environment variables show up in logs anywhere? Or in a docker ps type command? I believe the image is set up to read from all the standard locations for AWS config so we could also write to ~/.aws/credentials if these env variables would be visible anywhere.
There was a problem hiding this comment.
I'm not aware that those env vars would be visible. They will only show up on the Deployment/Pod like this:
Environment:
NESSIE_VERSION_STORE_TYPE: DYNAMO
AWS_REGION: us-west-2
AWS_ACCESS_KEY_ID: <set to the key 'aws_access_key_id' in secret 'awscreds'> Optional: false
AWS_SECRET_ACCESS_KEY: <set to the key 'aws_secret_access_key' in secret 'awscreds'> Optional: false
There was a problem hiding this comment.
actually inside the POD the secret will be exposed as a normal env var as described in https://kubernetes.io/docs/concepts/configuration/secret/#consuming-secret-values-from-environment-variables
This is just a fairly simple MVP version so that Nessie can be installed via Helm.
This change is