Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading GitHub token from path #238

Closed
h7x4 opened this issue Jul 21, 2023 · 3 comments
Closed

Allow reading GitHub token from path #238

h7x4 opened this issue Jul 21, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@h7x4
Copy link

h7x4 commented Jul 21, 2023

Hello!

I'm currently working on packaging this program up for NixOS, which I'll assume you at least have heard of since you have a nix flake in your repo.

Because of how nix works with a world-readable storage, it would make things a bit easier for us if we could pass a file path to the --github.token flag, in a similar fashion to --github.private_key. It would also allow other distros to use systemds LoadCredential to safely store and load the token.

Looking forward to your reply!

@tboerger
Copy link
Member

I think urfave/cli even got optical file support, that's something that would be quite easy to add.

@tboerger
Copy link
Member

I'm currently settling with something like file://path/to/secret/token.txt as you can see at #245, but it will result in a new major version because I will break some flags.

@tboerger
Copy link
Member

I have merged #245 now and the documentation have been updated.

@tboerger tboerger added the enhancement New feature or request label Oct 20, 2023
@tboerger tboerger added this to the v3.0.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants