Allow reading github token from path #239
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is an attempt at fixing #238. I had a look into urfave/cli, but it seems like the
FilePath
option they provide, only allows you to set default values from files, not override functionality.I'm a little bit unsure about the error logging. The logger seems to depend on the arguments, and the arguments (would) depend on the logger. I ended up just using standard
fmt
commands because I don't think it's worth the complexity, trying to partially parse arguments to set up a logger and then parse the rest. I could move the action function behind the part where the logger is created, but I think it makes sense to keep it as part of the command validation.I have not written any go code before, so if something looks weird, don't assume I had my reasons 😄
Closes #238