Admin collector #23
Closed
Admin collector #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm waiting for a developer license for GutHub Enterprise, I would like to give it a try first. |
mafrosis
commented
Dec 5, 2020
pkg/exporter/adminstats.go
Outdated
|
|
||
| // NewAdminStatsCollector returns a new AdminStatsCollector. | ||
| func NewAdminStatsCollector(logger log.Logger, client *github.Client, failures *prometheus.CounterVec, duration *prometheus.HistogramVec, cfg config.Target) *AdminStatsCollector { | ||
| failures.WithLabelValues("org").Add(0) |
There was a problem hiding this comment.
I noticed this should be adminstats. Let me know if you have any other feedback before I push a fix
|
Sadly GitHub never came back to me with a developer license :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new collector!
Simply wraps this API:
https://docs.github.com/en/[email protected]/rest/reference/enterprise-admin#admin-stats
Only contentious issue might be formatting - it was rather verbose and frankly just an enormous pile of boilerplate wrapping the go-github lib. So I made it more concise by removing a lot of line breaks..