Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): use status when missing conclusion #231

Conversation

ventsislav-georgiev
Copy link
Contributor

While a workflow is running the conclusion property is empty string. In order for the metric to provide the other states we can use the status property.

Related to: #230

@tboerger tboerger merged commit 6b98320 into promhippie:master Jul 13, 2023
2 of 3 checks passed
tboerger added a commit that referenced this pull request Jul 13, 2023
@tboerger tboerger added the bug Something isn't working label Jul 13, 2023
@tboerger tboerger added this to the v2.3.0 milestone Jul 13, 2023
@ventsislav-georgiev ventsislav-georgiev deleted the use-status-when-missing-conclusion branch July 25, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants