-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protobuf version #6898
Update protobuf version #6898
Conversation
@TeBoring some the PHP files have changed. Do you know why? |
My php fix has some protoc change. That’s expected
…On Fri, Nov 15, 2019 at 11:51 Rafi Kamal ***@***.***> wrote:
@TeBoring <https://github.com/TeBoring> some the PHP files have changed.
Do you know why?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6898?email_source=notifications&email_token=ABHUPZJN4O2S2XGGDH2KUE3QT34VLA5CNFSM4JN7O5A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEGQ4CI#issuecomment-554503689>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHUPZNQEZELWTFCKGMUUNLQT34VLANCNFSM4JN7O5AQ>
.
|
The Bazel tests are failing with the following error:
@ejona86 could this be related to the javalite stuffs you have been working on? |
Actually, the failure seems to be unrelated to Eric's change (grpc/grpc-java#6424). That change was submitting yesterday, our tests started failing from this noon (https://g3c.corp.google.com/results/invocations;query=protobuf%2Fgithub%2Fmaster%2Fubuntu%2Fbazel%2Fpresubmit). |
Looks like our javalite branch got vanished somehow. I've restored the branch, hopefully that will fix the error. |
No description provided.