Correct @return in Any.unpack docblock #7089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://docs.phpdoc.org/latest/references/phpdoc/tags/return.html, the first token after the @return tag should be the return type.
|
Gonna bump this as this is also breaking our ci/cd. Would be a huge win for us if we could get this merged! |
|
I second this👍🏻 |
|
I need this |
TeBoring
suggested changes
Jan 20, 2020
| @@ -251,7 +251,7 @@ public function setValue($var) | |||
| * targeted message type. If failed, an error will be thrown. Otherwise, | |||
| * the method will create a message of the targeted type and fill it with | |||
| * the decoded value in Any. | |||
| * @return unpacked message | |||
| * @return Message unpacked message | |||
There was a problem hiding this comment.
Should this be \Google\Protobuf\Internal\Message
There was a problem hiding this comment.
The class already has a use \Google\Protobuf\Internal\Message, so the namespace is unnecessary.
TeBoring
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://docs.phpdoc.org/latest/references/phpdoc/tags/return.html, the first token after the @return tag should be the return type.