Upload z3 built by vcpkg as release assets in CI. Maybe test whether it works in CI later. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use vcpkg-rs to manage z3 instead. A non-default feature vcpkg is added. However, vcpkg-rs does not support wasm32 target currently. I created a pull request there at mcgoo/vcpkg-rs#53
Make emscripten visible to wasm32-unknown-unknown if emscripten is installed.
Z3_HEADER_VAR will disappear when the feature vcpkg is enabled.
Use is_err instead of pattern matching.
Added missing cargo:rerun-if-changed for header.
This reverts commit 0df54a2.
So that rust can continue to build.
By this, we can check whether the toolchain matches the vcpkg triplet.
I couldn't find the button.
Create directory before it's used.
Not elegant in some aspects.
Added a vertical line.
Otherwise things will be too big.
TheVeryDarkness
changed the title
|
The test failed because there is no such release 0.12.2 here and it doesn't have write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release name
0.12.2is in env.Z3_VERSION and may be changed toz3-0.12.2if expected.Uploaded files in my fork is in 0.12.2.
I didn't attach a SHA256 or other validation information, and this may be added in the future.
And I may also add some codes to let z3-sys download and test uploaded archive. But archive for Windows is just too big, can we cache downloaded archive globally? Or add an env var that points to the archive？